Skip to content

Comments

OCPBUGS-64929: coreos-installer iso kargs show broken on OVE Agent ISO#656

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
pawanpinjarkar:update-assisted-image-service-dependency
Feb 2, 2026
Merged

OCPBUGS-64929: coreos-installer iso kargs show broken on OVE Agent ISO#656
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
pawanpinjarkar:update-assisted-image-service-dependency

Conversation

@pawanpinjarkar
Copy link
Contributor

@pawanpinjarkar pawanpinjarkar commented Feb 2, 2026 •
edited
Loading

Vendor latest assisted-image-service commit 503834119b3e. This fixes broken iso kargs show results.

coreos-installer iso kargs show agent-ove.x86_64.iso
rw  coreos.liveiso=rhcos-9.6.20251023-0 ignition.firstboot ignition.platform.id=metal

@pawanpinjarkar
OCPBUGS-64929: coreos-installer iso kargs show broken on OVE Agent ISO
b06ac2e 
Vendor latest assisted-image-service commit 503834119b3e
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Feb 2, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 2, 2026

@pawanpinjarkar: This pull request references Jira Issue OCPBUGS-64929, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mhanss

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Vendor latest assisted-image-service commit 503834119b3e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@danielerez
Copy link
Contributor

danielerez commented Feb 2, 2026

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 2, 2026

@pawanpinjarkar: This pull request references Jira Issue OCPBUGS-64929, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mhanss

Details

In response to this:

Vendor latest assisted-image-service commit 503834119b3e. This fixes broken iso kargs show results.

coreos-installer iso kargs show agent-ove.x86_64.iso
rw  coreos.liveiso=rhcos-9.6.20251023-0 ignition.firstboot ignition.platform.id=metal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pawanpinjarkar
Copy link
Contributor Author

pawanpinjarkar commented Feb 2, 2026

/cherrypick release-4.21, release-4.20

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 2, 2026

@pawanpinjarkar: once the present PR merges, I will cherry-pick it on top of release-4.21, in a new PR and assign it to you.

Details

In response to this:

/cherrypick release-4.21, release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pawanpinjarkar
Copy link
Contributor Author

pawanpinjarkar commented Feb 2, 2026

/cc @zaneb @danielerez

@openshift-ci openshift-ci bot requested review from danielerez and zaneb February 2, 2026 18:09
@openshift-ci
Copy link

openshift-ci bot commented Feb 2, 2026

@pawanpinjarkar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@danielerez
Copy link
Contributor

danielerez commented Feb 2, 2026

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2026
@openshift-ci
Copy link

openshift-ci bot commented Feb 2, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielerez, pawanpinjarkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2026
@openshift-merge-bot openshift-merge-bot bot merged commit d60124e into openshift:master Feb 2, 2026
8 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 2, 2026

@pawanpinjarkar: Jira Issue OCPBUGS-64929: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-64929 has been moved to the MODIFIED state.

Details

In response to this:

Vendor latest assisted-image-service commit 503834119b3e. This fixes broken iso kargs show results.

coreos-installer iso kargs show agent-ove.x86_64.iso
rw  coreos.liveiso=rhcos-9.6.20251023-0 ignition.firstboot ignition.platform.id=metal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 2, 2026

@pawanpinjarkar: cannot checkout release-4.21,: error checking out "release-4.21,": exit status 1 error: pathspec 'release-4.21,' did not match any file(s) known to git

Details

In response to this:

/cherrypick release-4.21, release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pawanpinjarkar
Copy link
Contributor Author

pawanpinjarkar commented Feb 3, 2026

/cherrypick release-4.21

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 3, 2026

@pawanpinjarkar: #656 failed to apply on top of branch "release-4.21":

Applying: OCPBUGS-64929: coreos-installer iso kargs show broken on OVE Agent ISO Vendor latest assisted-image-service commit 503834119b3e
Using index info to reconstruct a base tree...
M	go.mod
M	go.sum
Falling back to patching base and 3-way merge...
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 OCPBUGS-64929: coreos-installer iso kargs show broken on OVE Agent ISO Vendor latest assisted-image-service commit 503834119b3e
Details

In response to this:

/cherrypick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

zaneb
zaneb reviewed Feb 3, 2026
View reviewed changes
go.mod
github.com/pelletier/go-toml v1.9.5
github.com/pkg/errors v0.9.1
github.com/sirupsen/logrus v1.9.4-0.20251023124752-b61f268f75b6
github.com/sirupsen/logrus v1.9.4
Copy link
Member

@zaneb zaneb Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we dropped the change from #580, but I'm unclear on the significance of that.

Copy link
Contributor Author

@pawanpinjarkar pawanpinjarkar Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I discussed with @danielerez. As suggested, its not crucial, the konflux bot should handle it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhanss mhanss Awaiting requested review from mhanss

@avishayt avishayt Awaiting requested review from avishayt

@oourfali oourfali Awaiting requested review from oourfali

@danielerez danielerez Awaiting requested review from danielerez

1 more reviewer

@zaneb zaneb zaneb left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@danielerez danielerez

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pawanpinjarkar @openshift-ci-robot @danielerez @openshift-cherrypick-robot @zaneb